Neutrino crashed after get_bouquets_as_dropdown call

Entwicklung
Antworten
Benny
Interessierter
Interessierter
Beiträge: 57
Registriert: Samstag 17. Mai 2014, 17:28
Sonstiges: GM990

Neutrino crashed after get_bouquets_as_dropdown call

Beitrag von Benny »

Greetings,

old problem with LiveTV and EPG+ in web interface - after calling internal function "get_bouquets_as_dropdown" Neutrino crashed with

Code: Alles auswählen

*** glibc detected *** neutrino: double free or corruption (!prev): 0x00a5cca8 ***
Affected files - Y_EPG_Plus.yhtm, Y_Live.yhtm. Quick workaround: comment out get_bouquets_as_dropdown call, something like

Code: Alles auswählen

function build_bouquet_list(bouquet){
	var used_bouquet = bouquet;
	if(used_bouquet == -1)
		used_bouquet = loadSyncURL("/y/cgi?execute=func:get_actual_bouquet_number");
	var bouquet_dropdown_url = used_bouquet + "{=if-empty:{=var-get:must_management=}~~%20true=}";
// "/y/cgi?execute=func:get_bouquets_as_dropdown%20" +
	var bouquet_dropdown = "<select size=\"1\" class=\"y_live_bouquets\" id=\"bouquets\" onchange=\"change_bouquet()\" title=\"{=L:live.select_bouquet=}\">";
	bouquet_dropdown += loadSyncURL(bouquet_dropdown_url);
	bouquet_dropdown += "<\/select>";
//	obj_update('bouquets_div', bouquet_dropdown);
	build_channel_list(used_bouquet, -1);
}
With this workaround LiveTV and EPG+ working normally within "current" bouquet.

Can something be done with this bug?

Thanks in advance.
martii
Einsteiger
Einsteiger
Beiträge: 217
Registriert: Donnerstag 14. Juni 2012, 08:39

Re: Neutrino crashed after get_bouquets_as_dropdown call

Beitrag von martii »

Hi Benny,

I can't reproduce that issue. Is this on Astra 19.2E?

(However, I did spot some weird tampering with a string object in the encodeString() function. No idea whether that's related.)

Cheers,

martii
Benny
Interessierter
Interessierter
Beiträge: 57
Registriert: Samstag 17. Mai 2014, 17:28
Sonstiges: GM990

Re: Neutrino crashed after get_bouquets_as_dropdown call

Beitrag von Benny »

martii hat geschrieben: Is this on Astra 19.2E?
Multi satellite setup, Russian locale and some channels have Russian names (yes, i know - rare config type in your location =))
martii hat geschrieben: No idea whether that's related
Looks like it was, at least after repo update Neutrino not crashed anymore.
But, as far i understand, now it encode string (which already utf8?) to "ampersand encoded" utf8 - why? As result - i got a "garbage" in drop-down list in web interface.
But, if i rebuild Neutrino with this fix in neutrinoyparser.cpp (line 238)

Code: Alles auswählen

			yresult += string_printf("<option value=%u %s>%s</option>\n", i + 1, sel.c_str(),
				g_bouquetManager->Bouquets[i]->lName.c_str());
ie, with "encodeString()" removed, its look fine. Did "encodeString()" really need in this case?
martii
Einsteiger
Einsteiger
Beiträge: 217
Registriert: Donnerstag 14. Juni 2012, 08:39

Re: Neutrino crashed after get_bouquets_as_dropdown call

Beitrag von martii »

Hi Benny,

thanks, I kind of expected that as the CST git no longer uses encodeString() in that function. Looks like I've messed up a git merge or cherry-pick some time ago. Fixed.

Cheers,

martii
Benny
Interessierter
Interessierter
Beiträge: 57
Registriert: Samstag 17. Mai 2014, 17:28
Sonstiges: GM990

Re: Neutrino crashed after get_bouquets_as_dropdown call

Beitrag von Benny »

martii hat geschrieben:Fixed
Thank you.
Antworten