Seite 1 von 1

HDD format in Neutrino-MP

Verfasst: Samstag 12. Juli 2014, 00:27
von Benny
Greetings,

ext3/4 HDD format failed, in logs looks like fdisk called with incorrect options. In neutrino-mp/src/gui/hdd_menu.cpp we have

Code: Alles auswählen

	fdisk   = find_executable("fdisk");
	sfdisk  = find_executable("sfdisk");
	mke3fs  = find_executable("mkfs.ext3");
	mke4fs  = find_executable("mkfs.ext4");
	tune2fs = find_executable("tune2fs");
	if (! fdisk.empty()) {                                                                     // should this look like 'if (! sfdisk.empty())'?
		snprintf(cmd, sizeof(cmd), "%s -f -uM /dev/%s", fdisk.c_str(), key.c_str()); // 'sfdisk.c_str()'?
		strcpy(cmd2, "0,\n;\n;\n;\ny\n");            // this branch failed, -f -M and further commands not valid for fdisk
	} else if (! fdisk.empty()) {
		snprintf(cmd, sizeof(cmd), "%s -u /dev/%s", fdisk.c_str(), key.c_str());
		strcpy(cmd2, "o\nn\np\n1\n2048\n\nw\n");
This is a typo?
PS Diff with fix attached

Re: HDD format in Neutrino-MP

Verfasst: Samstag 12. Juli 2014, 09:09
von doc
Care to create a git patch directly instead "only" a diff? That would make life much easier for the people with commit rights. :wink:

Re: HDD format in Neutrino-MP

Verfasst: Samstag 12. Juli 2014, 13:48
von martii
Benny hat geschrieben:PS Diff with fix attached
Applied, thanks!