Bug: Wrong extended event descriptor in EIT structure

Alles rund um das grafische Benutzerinterface Enigma
sestegra
Neugieriger
Neugieriger
Beiträge: 5
Registriert: Samstag 8. Mai 2004, 19:43

Bug: Wrong extended event descriptor in EIT structure

Beitrag von sestegra »

FILES: /cvs/tuxbox/apps/tuxbox/enigma/include/lib/dvb/lowlevel/eit.h
/cvs/tuxbox/apps/tuxbox/enigma/lib/dvb/si.cpp

SPEC: ETSI EN 300 468 §6.2.14.

EXPLANATION:
In eit_extended_descriptor_struct, remove last two bytes definitions as following.
...
u_char iso_639_2_language_code_3 : 8;
u_char length_of_items : 8; <= to remove
u_char item_description_length : 8; <= to remove

Items loop with several "item_description" and "item" pairs is generaly empty (i.e. length of items = 0). With no item in loop bug doesn't appears because "item_decription_length" is used as "text_length" and following "text_char" is take into account.

But on Canalsatellite transponders, events could contain items loop (with one or several items) and could contain several extended_descriptor.

As a result EPG displays not understandable text.
tmbinc
Developer
Beiträge: 821
Registriert: Freitag 20. Juli 2001, 00:00

Beitrag von tmbinc »

the fix should be contained in http://developer.elitedvb.net/files/72/eit_fix.diff , can you please check if it works?
sestegra
Neugieriger
Neugieriger
Beiträge: 5
Registriert: Samstag 8. Mai 2004, 19:43

Beitrag von sestegra »

I prefer this following patch instead of yours, because Items could be processed for future use : I suppose next days.

(edit: removed patch because of readability, hope it's ok - tmbinc)
tmbinc
Developer
Beiträge: 821
Registriert: Freitag 20. Juli 2001, 00:00

Beitrag von tmbinc »

you're right, applied.

one question: why do you ignore the charset? convertDVBUTF8 should handle them fine, using "table" as default.
sestegra
Neugieriger
Neugieriger
Beiträge: 5
Registriert: Samstag 8. Mai 2004, 19:43

Beitrag von sestegra »

I only copy behavior of ShortEventDescriptor.

See line 701 in si.cpp file.